From: Peter Zijlstra Date: Thu, 29 Oct 2020 15:32:22 +0000 (+0100) Subject: perf: Tweak perf_event_attr::exclusive semantics X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=1908dc911792067287458fdb0800f036f4f4e0f6;p=linux.git perf: Tweak perf_event_attr::exclusive semantics Currently perf_event_attr::exclusive can be used to ensure an event(group) is the sole group scheduled on the PMU. One consequence is that when you have a pinned event (say the watchdog) you can no longer have regular exclusive event(group)s. Inspired by the fact that !pinned events are considered less strict, allow !pinned,exclusive events to share the PMU with pinned,!exclusive events. Pinned,exclusive is still fully exclusive. Signed-off-by: Peter Zijlstra (Intel) Link: https://lkml.kernel.org/r/20201029162902.105962225@infradead.org --- diff --git a/kernel/events/core.c b/kernel/events/core.c index 00be48acdc360..dc568ca295bdc 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -2637,7 +2637,7 @@ static int group_can_go_on(struct perf_event *event, * If this group is exclusive and there are already * events on the CPU, it can't go on. */ - if (event->attr.exclusive && cpuctx->active_oncpu) + if (event->attr.exclusive && !list_empty(get_event_list(event))) return 0; /* * Otherwise, try to add it if all previous groups were able