From: Minjie Du Date: Thu, 13 Jul 2023 04:24:12 +0000 (+0800) Subject: thermal/drivers/mediatek/lvts: Fix parameter check in lvts_debugfs_init() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=19ad9f29751ca385262c63f513f75610962c40a0;p=linux.git thermal/drivers/mediatek/lvts: Fix parameter check in lvts_debugfs_init() The documentation says "If an error occurs, ERR_PTR(-ERROR) will be returned" but the current code checks against a NULL pointer returned. Fix this by checking if IS_ERR(). Signed-off-by: Minjie Du Signed-off-by: Daniel Lezcano Link: https://lore.kernel.org/r/20230713042413.2519-1-duminjie@vivo.com --- diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c index 61c3de44c40ba..bc726ac0a672e 100644 --- a/drivers/thermal/mediatek/lvts_thermal.c +++ b/drivers/thermal/mediatek/lvts_thermal.c @@ -201,7 +201,7 @@ static int lvts_debugfs_init(struct device *dev, struct lvts_domain *lvts_td) int i; lvts_td->dom_dentry = debugfs_create_dir(dev_name(dev), NULL); - if (!lvts_td->dom_dentry) + if (IS_ERR(lvts_td->dom_dentry)) return 0; for (i = 0; i < lvts_td->num_lvts_ctrl; i++) {