From: Eric Sesterhenn <snakebyte@gmx.de> Date: Wed, 19 Apr 2006 04:09:20 +0000 (-0700) Subject: [SCSI] Overrun in drivers/scsi/sim710.c X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=1a34456bbbdaa939ffa567d15a0797c269f901b7;p=linux.git [SCSI] Overrun in drivers/scsi/sim710.c This fixes coverity bug id #480. Since id_array is declared as id_array[MAX_SLOTS], the check for i>MAX_SLOTS is obviously false. Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de> Cc: James Bottomley <James.Bottomley@steeleye.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com> --- diff --git a/drivers/scsi/sim710.c b/drivers/scsi/sim710.c index 3274ab76c8d39..255886a9ac55c 100644 --- a/drivers/scsi/sim710.c +++ b/drivers/scsi/sim710.c @@ -75,7 +75,7 @@ param_setup(char *str) else if(!strncmp(pos, "id:", 3)) { if(slot == -1) { printk(KERN_WARNING "sim710: Must specify slot for id parameter\n"); - } else if(slot > MAX_SLOTS) { + } else if(slot >= MAX_SLOTS) { printk(KERN_WARNING "sim710: Illegal slot %d for id %d\n", slot, val); } else { id_array[slot] = val;