From: Jean Sacren Date: Sat, 16 Oct 2021 05:41:34 +0000 (-0600) Subject: net: macvtap: fix template string argument of device_create() call X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=1c5b5b3f0eab5eb8d954816dbb3124d2411fd800;p=linux.git net: macvtap: fix template string argument of device_create() call The last argument of device_create() call should be a template string. The tap_name variable should be the argument to the string, but not the argument of the call itself. We should add the template string and turn tap_name into its argument. Signed-off-by: Jean Sacren Signed-off-by: David S. Miller --- diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c index 694e2f5dbbe59..6b12902a803f0 100644 --- a/drivers/net/macvtap.c +++ b/drivers/net/macvtap.c @@ -169,7 +169,7 @@ static int macvtap_device_event(struct notifier_block *unused, devt = MKDEV(MAJOR(macvtap_major), vlantap->tap.minor); classdev = device_create(&macvtap_class, &dev->dev, devt, - dev, tap_name); + dev, "%s", tap_name); if (IS_ERR(classdev)) { tap_free_minor(macvtap_major, &vlantap->tap); return notifier_from_errno(PTR_ERR(classdev));