From: Masahiro Yamada Date: Wed, 11 Mar 2020 06:29:25 +0000 (+0900) Subject: net: drop_monitor: use IS_REACHABLE() to guard net_dm_hw_report() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=1cd9b3abf5332102d4d967555e7ed861a75094bf;p=linux.git net: drop_monitor: use IS_REACHABLE() to guard net_dm_hw_report() In net/Kconfig, NET_DEVLINK implies NET_DROP_MONITOR. The original behavior of the 'imply' keyword prevents NET_DROP_MONITOR from being 'm' when NET_DEVLINK=y. With the planned Kconfig change that relaxes the 'imply', the combination of NET_DEVLINK=y and NET_DROP_MONITOR=m would be allowed. Use IS_REACHABLE() to avoid the vmlinux link error for this case. Reported-by: Stephen Rothwell Signed-off-by: Masahiro Yamada Acked-by: Neil Horman --- diff --git a/include/net/drop_monitor.h b/include/net/drop_monitor.h index 2ab668461463e..f68bc373544a9 100644 --- a/include/net/drop_monitor.h +++ b/include/net/drop_monitor.h @@ -19,7 +19,7 @@ struct net_dm_hw_metadata { struct net_device *input_dev; }; -#if IS_ENABLED(CONFIG_NET_DROP_MONITOR) +#if IS_REACHABLE(CONFIG_NET_DROP_MONITOR) void net_dm_hw_report(struct sk_buff *skb, const struct net_dm_hw_metadata *hw_metadata); #else