From: Stephane Grosjean Date: Fri, 25 Jun 2021 13:09:27 +0000 (+0200) Subject: can: peak_usb: pcan_usb_get_device_id(): read value only in case of success X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=1d0214a0f5db10d5dc37f4da980786cd094ae3e4;p=linux.git can: peak_usb: pcan_usb_get_device_id(): read value only in case of success In case of error, reading value from response argument is useless. Link: https://lore.kernel.org/r/20210625130931.27438-2-s.grosjean@peak-system.com Signed-off-by: Stephane Grosjean Signed-off-by: Marc Kleine-Budde --- diff --git a/drivers/net/can/usb/peak_usb/pcan_usb.c b/drivers/net/can/usb/peak_usb/pcan_usb.c index 1d6f77252f018..9f3e16684e289 100644 --- a/drivers/net/can/usb/peak_usb/pcan_usb.c +++ b/drivers/net/can/usb/peak_usb/pcan_usb.c @@ -384,7 +384,8 @@ static int pcan_usb_get_device_id(struct peak_usb_device *dev, u32 *device_id) if (err) netdev_err(dev->netdev, "getting device id failure: %d\n", err); - *device_id = args[0]; + else + *device_id = args[0]; return err; }