From: Paolo Bonzini <pbonzini@redhat.com>
Date: Tue, 2 Apr 2024 10:26:36 +0000 (+0200)
Subject: vga: do not treat horiz pel panning value of 8 as "enabled"
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=1d1ee7e0a1b7041804e8c5f8c2453fdc2df0407e;p=qemu.git

vga: do not treat horiz pel panning value of 8 as "enabled"

Horizontal pel panning bit 3 is only used in text mode.  In graphics
mode, it can be treated as if it was zero, thus not extending the
dirty memory region.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---

diff --git a/hw/display/vga.c b/hw/display/vga.c
index 40acd19e72..77f59e8c11 100644
--- a/hw/display/vga.c
+++ b/hw/display/vga.c
@@ -1571,7 +1571,9 @@ static void vga_draw_graphic(VGACommonState *s, int full_update)
             break;
         }
     }
-    hpel = bits <= 8 ? s->params.hpel : 0;
+
+    /* Horizontal pel panning bit 3 is only used in text mode.  */
+    hpel = bits <= 8 ? s->params.hpel & 7 : 0;
 
     region_start = (s->params.start_addr * 4);
     region_end = region_start + (ram_addr_t)s->params.line_offset * height;