From: Colin Ian King Date: Fri, 9 Aug 2019 17:59:32 +0000 (+0100) Subject: scsi: sym53c8xx_2: remove redundant assignment to retv X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=1d4f4a5e507f5879af56370380df600dd9119030;p=linux.git scsi: sym53c8xx_2: remove redundant assignment to retv Variable retv is initialized to a value that is never read and it is re-assigned later. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King Acked-by: Matthew Wilcox (Oracle) Signed-off-by: Martin K. Petersen --- diff --git a/drivers/scsi/sym53c8xx_2/sym_nvram.c b/drivers/scsi/sym53c8xx_2/sym_nvram.c index dd3f07b316120..9dc17f1288f9a 100644 --- a/drivers/scsi/sym53c8xx_2/sym_nvram.c +++ b/drivers/scsi/sym53c8xx_2/sym_nvram.c @@ -648,7 +648,7 @@ static int sym_read_T93C46_nvram(struct sym_device *np, Tekram_nvram *nvram) { u_char gpcntl, gpreg; u_char old_gpcntl, old_gpreg; - int retv = 1; + int retv; /* save current state of GPCNTL and GPREG */ old_gpreg = INB(np, nc_gpreg);