From: Jules Irenge Date: Sat, 11 Apr 2020 00:19:30 +0000 (+0100) Subject: scsi: libsas: Add missing annotation for sas_ata_qc_issue() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=1e4ffb8344c53b3d8297c9591c59debe4406e6cb;p=linux.git scsi: libsas: Add missing annotation for sas_ata_qc_issue() Sparse reports a warning at sas_ata_qc_issue() warning: context imbalance in sas_ata_qc_issue() - unexpected unlock The root cause is the missing annotation at sas_ata_qc_issue() Add the missing __must_hold(ap->lock) annotation Link: https://lore.kernel.org/r/20200411001933.10072-7-jbi.octave@gmail.com Reviewed-by: John Garry Signed-off-by: Jules Irenge Signed-off-by: Martin K. Petersen --- diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c index c5a828a041e07..5d716d3887071 100644 --- a/drivers/scsi/libsas/sas_ata.c +++ b/drivers/scsi/libsas/sas_ata.c @@ -160,6 +160,7 @@ qc_already_gone: } static unsigned int sas_ata_qc_issue(struct ata_queued_cmd *qc) + __must_hold(ap->lock) { struct sas_task *task; struct scatterlist *sg;