From: Jonathan Cameron Date: Sun, 17 Oct 2021 16:03:03 +0000 (+0100) Subject: iio: accel: sca3000: Use sign_extend32() instead of opencoding sign extension. X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=1ea3615b6168eaaf07445c8d32a4c6bc965d9579;p=linux.git iio: accel: sca3000: Use sign_extend32() instead of opencoding sign extension. Whilst nice to get rid of this non obvious code, this also clears a static checker warning: drivers/iio/accel/sca3000.c:734 sca3000_read_raw() warn: no-op. '((*val) << 19) >> 19' Reported-by: Dan Carpenter Signed-off-by: Jonathan Cameron Reviewed-by: Lars-Peter Clausen Link: https://lore.kernel.org/r/20211017160303.72441-1-jic23@kernel.org --- diff --git a/drivers/iio/accel/sca3000.c b/drivers/iio/accel/sca3000.c index cb753a43533cd..c6b75308148aa 100644 --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -731,8 +731,7 @@ static int sca3000_read_raw(struct iio_dev *indio_dev, return ret; } *val = (be16_to_cpup((__be16 *)st->rx) >> 3) & 0x1FFF; - *val = ((*val) << (sizeof(*val) * 8 - 13)) >> - (sizeof(*val) * 8 - 13); + *val = sign_extend32(*val, 12); } else { /* get the temperature when available */ ret = sca3000_read_data_short(st,