From: Christophe JAILLET Date: Sat, 21 May 2022 06:59:35 +0000 (+0200) Subject: spi: intel: Use correct order for the parameters of devm_kcalloc() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=1f19a2d1d6b9a5796182874eecdd5a67dd94b90c;p=linux.git spi: intel: Use correct order for the parameters of devm_kcalloc() We should have 'n', then 'size', not the opposite. This is harmless because the 2 values are just multiplied, but having the correct order silence a (unpublished yet) smatch warning. Signed-off-by: Christophe JAILLET Link: https://lore.kernel.org/r/d114558dd0351b863ced8cc01b31754a5a4b960d.1653116362.git.christophe.jaillet@wanadoo.fr Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-intel.c b/drivers/spi/spi-intel.c index 50f42983b9502..66063687ae271 100644 --- a/drivers/spi/spi-intel.c +++ b/drivers/spi/spi-intel.c @@ -1236,8 +1236,8 @@ static int intel_spi_populate_chip(struct intel_spi *ispi) return -ENOMEM; pdata->nr_parts = 1; - pdata->parts = devm_kcalloc(ispi->dev, sizeof(*pdata->parts), - pdata->nr_parts, GFP_KERNEL); + pdata->parts = devm_kcalloc(ispi->dev, pdata->nr_parts, + sizeof(*pdata->parts), GFP_KERNEL); if (!pdata->parts) return -ENOMEM;