From: Alex Elder <elder@linaro.org>
Date: Fri, 28 Feb 2020 18:33:59 +0000 (-0600)
Subject: remoteproc: return error for bad "recovery" debugfs input
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=1f2f65c41034accf9baf684c0dae756b56fac19f;p=linux.git

remoteproc: return error for bad "recovery" debugfs input

If the value written to the "recovery" debugfs file is not one of
the recognized commands return an error to indicate it's invalid.

Signed-off-by: Alex Elder <elder@linaro.org>
Link: https://lore.kernel.org/r/20200228183359.16229-5-elder@linaro.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---

diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c
index b87565a13eb1e..d734cadb16e3e 100644
--- a/drivers/remoteproc/remoteproc_debugfs.c
+++ b/drivers/remoteproc/remoteproc_debugfs.c
@@ -146,6 +146,8 @@ rproc_recovery_write(struct file *filp, const char __user *user_buf,
 	} else if (!strncmp(buf, "recover", count)) {
 		/* begin the recovery process without changing the flag */
 		rproc_trigger_recovery(rproc);
+	} else {
+		return -EINVAL;
 	}
 
 	return count;