From: Paolo Bonzini <pbonzini@redhat.com>
Date: Thu, 29 Nov 2018 08:30:59 +0000 (+0100)
Subject: checkpatch: fix premature exit when no input or --mailback
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=1ff7ebf33b67b4ec7ea663827e74fe54ac469618;p=qemu.git

checkpatch: fix premature exit when no input or --mailback

In some cases, checkpatch's process subroutine is exiting the
whole process.  This is wrong, just return from the subroutine
instead.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 18e16b79df..66eb68e85a 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2867,19 +2867,19 @@ sub process {
 	# If we have no input at all, then there is nothing to report on
 	# so just keep quiet.
 	if ($#rawlines == -1) {
-		exit(0);
+		return 1;
 	}
 
 	# In mailback mode only produce a report in the negative, for
 	# things that appear to be patches.
 	if ($mailback && ($clean == 1 || !$is_patch)) {
-		exit(0);
+		return 1;
 	}
 
 	# This is not a patch, and we are are in 'no-patch' mode so
 	# just keep quiet.
 	if (!$chk_patch && !$is_patch) {
-		exit(0);
+		return 1;
 	}
 
 	if (!$is_patch) {