From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 29 Jul 2009 08:39:59 +0000 (+0200)
Subject: qemu-option: fix parse_option_number().
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=21c9f4cdc63f4ab85f7271b5d6de999ad74d4488;p=qemu.git

qemu-option: fix parse_option_number().

It works much better when parse_option_number actually
returns the number parsed ...

Common breakage resulting from this bug is that
'qemu -hda foo.img -cdrom bar.iso' stops working
(cdrom isn't there).

Cc: Avi Kivity <avi@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---

diff --git a/qemu-option.c b/qemu-option.c
index 73c2175492..591d178999 100644
--- a/qemu-option.c
+++ b/qemu-option.c
@@ -193,6 +193,7 @@ static int parse_option_number(const char *name, const char *value, uint64_t *re
             fprintf(stderr, "Option '%s' needs a number as parameter\n", name);
             return -1;
         }
+        *ret = number;
     } else {
         fprintf(stderr, "Option '%s' needs a parameter\n", name);
         return -1;