From: Yang Yingliang Date: Thu, 9 Sep 2021 09:06:08 +0000 (+0800) Subject: n64cart: fix return value check in n64cart_probe() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=221e8360834c59f0c9952630fa5904a94ebd2bb8;p=linux.git n64cart: fix return value check in n64cart_probe() In case of error, the function devm_platform_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: d9b2a2bbbb4d ("block: Add n64 cart driver") Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Reviewed-by: Chaitanya Kulkarni Link: https://lore.kernel.org/r/20210909090608.2989716-1-yangyingliang@huawei.com Signed-off-by: Jens Axboe --- diff --git a/drivers/block/n64cart.c b/drivers/block/n64cart.c index c84be0028f635..26798da661bd4 100644 --- a/drivers/block/n64cart.c +++ b/drivers/block/n64cart.c @@ -129,8 +129,8 @@ static int __init n64cart_probe(struct platform_device *pdev) } reg_base = devm_platform_ioremap_resource(pdev, 0); - if (!reg_base) - return -EINVAL; + if (IS_ERR(reg_base)) + return PTR_ERR(reg_base); disk = blk_alloc_disk(NUMA_NO_NODE); if (!disk)