From: Alexander Stein Date: Tue, 7 Feb 2023 11:05:30 +0000 (+0100) Subject: of: device: Do not ignore error code in of_device_uevent_modalias X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=2295bed9bebe8d1eef276194fed5b5fbe89c5363;p=linux.git of: device: Do not ignore error code in of_device_uevent_modalias of_device_get_modalias might return an error code, propagate that one. Otherwise the negative, signed integer is propagated to unsigned integer for the comparison resulting in a huge 'sl' size. Signed-off-by: Alexander Stein Reviewed-by: Rob Herring Link: https://lore.kernel.org/r/20230207110531.1060252-3-alexander.stein@ew.tq-group.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/of/device.c b/drivers/of/device.c index 3caaaf1070766..8271793ef3790 100644 --- a/drivers/of/device.c +++ b/drivers/of/device.c @@ -385,6 +385,8 @@ int of_device_uevent_modalias(struct device *dev, struct kobj_uevent_env *env) sl = of_device_get_modalias(dev, &env->buf[env->buflen-1], sizeof(env->buf) - env->buflen); + if (sl < 0) + return sl; if (sl >= (sizeof(env->buf) - env->buflen)) return -ENOMEM; env->buflen += sl;