From: Al Viro <viro@zeniv.linux.org.uk>
Date: Tue, 5 Jan 2021 19:19:11 +0000 (-0500)
Subject: make dump_common_audit_data() safe to be called from RCU pathwalk
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=23d8f5b684fc30126b7708cad38b753eaa078b3e;p=linux.git

make dump_common_audit_data() safe to be called from RCU pathwalk

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---

diff --git a/security/lsm_audit.c b/security/lsm_audit.c
index a0cd28cd31a85..82ce149335138 100644
--- a/security/lsm_audit.c
+++ b/security/lsm_audit.c
@@ -291,18 +291,19 @@ static void dump_common_audit_data(struct audit_buffer *ab,
 		struct dentry *dentry;
 		struct inode *inode;
 
+		rcu_read_lock();
 		inode = a->u.inode;
-		dentry = d_find_alias(inode);
+		dentry = d_find_alias_rcu(inode);
 		if (dentry) {
 			audit_log_format(ab, " name=");
 			spin_lock(&dentry->d_lock);
 			audit_log_untrustedstring(ab, dentry->d_name.name);
 			spin_unlock(&dentry->d_lock);
-			dput(dentry);
 		}
 		audit_log_format(ab, " dev=");
 		audit_log_untrustedstring(ab, inode->i_sb->s_id);
 		audit_log_format(ab, " ino=%lu", inode->i_ino);
+		rcu_read_unlock();
 		break;
 	}
 	case LSM_AUDIT_DATA_TASK: {