From: Greg Kurz Date: Mon, 6 Mar 2017 16:34:01 +0000 (+0100) Subject: 9pfs: fail local_statfs() earlier X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=23da0145cc4be66fdb1033f951dbbf140f457896;p=qemu.git 9pfs: fail local_statfs() earlier If we cannot open the given path, we can return right away instead of passing -1 to fstatfs() and close(). This will make Coverity happy. (Coverity issue CID1371729) Signed-off-by: Greg Kurz Reviewed-by: Daniel P. berrange Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé --- diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c index 09f6a46d61..6d16c4a065 100644 --- a/hw/9pfs/9p-local.c +++ b/hw/9pfs/9p-local.c @@ -1053,6 +1053,9 @@ static int local_statfs(FsContext *s, V9fsPath *fs_path, struct statfs *stbuf) int fd, ret; fd = local_open_nofollow(s, fs_path->data, O_RDONLY, 0); + if (fd == -1) { + return -1; + } ret = fstatfs(fd, stbuf); close_preserve_errno(fd); return ret;