From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Wed, 30 Mar 2022 14:59:10 +0000 (+0300)
Subject: gpiolib: Move error message out of a spinlock
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=24a9dbb1c1575b9890bb7d9028cc89894da6dc22;p=linux.git

gpiolib: Move error message out of a spinlock

An error path is a slow path, no need to block other CPUs
when printing error messages.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 3ffe7b6cebbf4..1e4aa358e606d 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -288,7 +288,6 @@ static int gpiodev_add_to_list(struct gpio_device *gdev)
 		}
 	}
 
-	dev_err(&gdev->dev, "GPIO integer space overlap, cannot add chip\n");
 	return -EBUSY;
 }
 
@@ -727,6 +726,7 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data,
 	ret = gpiodev_add_to_list(gdev);
 	if (ret) {
 		spin_unlock_irqrestore(&gpio_lock, flags);
+		chip_err(gc, "GPIO integer space overlap, cannot add chip\n");
 		goto err_free_label;
 	}