From: Jia-Ju Bai Date: Wed, 11 Apr 2018 03:07:32 +0000 (+0800) Subject: misc: ti-st: Replace GFP_ATOMIC with GFP_KERNEL in kim_probe X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=24b6d3eee183ddde814b47aedc7f0c0c5ab7b72d;p=linux.git misc: ti-st: Replace GFP_ATOMIC with GFP_KERNEL in kim_probe kim_probe() is never called in atomic context. This function is only set as ".probe" in struct platform_driver. Despite never getting called from atomic context, kim_probe() calls kzalloc() with GFP_ATOMIC, which does not sleep for allocation. GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, which can sleep and improve the possibility of sucessful allocation. This is found by a static analysis tool named DCNS written by myself. And I also manually check it. Signed-off-by: Jia-Ju Bai Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c index b77aacafc3fcd..5ec3f5a437187 100644 --- a/drivers/misc/ti-st/st_kim.c +++ b/drivers/misc/ti-st/st_kim.c @@ -735,7 +735,7 @@ static int kim_probe(struct platform_device *pdev) st_kim_devices[0] = pdev; } - kim_gdata = kzalloc(sizeof(struct kim_data_s), GFP_ATOMIC); + kim_gdata = kzalloc(sizeof(struct kim_data_s), GFP_KERNEL); if (!kim_gdata) { pr_err("no mem to allocate"); return -ENOMEM;