From: Alexandru Ardelean Date: Thu, 19 Nov 2020 14:27:20 +0000 (+0200) Subject: iio: adc: ad7292: remove unneeded spi_set_drvdata() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=24da9627e674305187a9908b328ffabcca65e2b5;p=linux.git iio: adc: ad7292: remove unneeded spi_set_drvdata() This seems to have been copied from a driver that calls spi_set_drvdata() but doesn't call spi_get_drvdata(). Setting a private object on the SPI device's object isn't necessary if it won't be accessed. This change removes the spi_set_drvdata() call. Signed-off-by: Alexandru Ardelean Tested-by: Marcelo Schmitt Reviewed-by: Marcelo Schmitt Link: https://lore.kernel.org/r/20201119142720.86326-1-alexandru.ardelean@analog.com Signed-off-by: Jonathan Cameron --- diff --git a/drivers/iio/adc/ad7292.c b/drivers/iio/adc/ad7292.c index ab204e9199e99..70e33dd1c9f72 100644 --- a/drivers/iio/adc/ad7292.c +++ b/drivers/iio/adc/ad7292.c @@ -276,8 +276,6 @@ static int ad7292_probe(struct spi_device *spi) return -EINVAL; } - spi_set_drvdata(spi, indio_dev); - st->reg = devm_regulator_get_optional(&spi->dev, "vref"); if (!IS_ERR(st->reg)) { ret = regulator_enable(st->reg);