From: Daniel P. Berrange <berrange@redhat.com>
Date: Tue, 8 Mar 2016 12:06:45 +0000 (+0000)
Subject: io: set correct error object in background reader test thread
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=256920eb94f4de9430122b7618b9c2a16cb2df32;p=qemu.git

io: set correct error object in background reader test thread

The reader thread was accidentally setting the error pointer
intended for the writer thread. If both threads set errors
this would result in QEMU abort'ing due to the error already
being set.

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---

diff --git a/tests/io-channel-helpers.c b/tests/io-channel-helpers.c
index 844066904b..d513792068 100644
--- a/tests/io-channel-helpers.c
+++ b/tests/io-channel-helpers.c
@@ -132,7 +132,7 @@ static gpointer test_io_thread_reader(gpointer opaque)
 
         if (ret == QIO_CHANNEL_ERR_BLOCK) {
             if (data->blocking) {
-                error_setg(&data->writeerr,
+                error_setg(&data->readerr,
                            "Unexpected I/O blocking");
                 break;
             } else {