From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 3 May 2018 10:54:32 +0000 (+0300)
Subject: scsi: megaraid: silence a static checker bug
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=27e833dabab74ee665e487e291c9afc6d71effba;p=linux.git

scsi: megaraid: silence a static checker bug

If we had more than 32 megaraid cards then it would cause memory
corruption.  That's not likely, of course, but it's handy to enforce it
and make the static checker happy.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
---

diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
index 7195cff51d4c4..9b6f5d024dbae 100644
--- a/drivers/scsi/megaraid.c
+++ b/drivers/scsi/megaraid.c
@@ -4199,6 +4199,9 @@ megaraid_probe_one(struct pci_dev *pdev, const struct pci_device_id *id)
 	int irq, i, j;
 	int error = -ENODEV;
 
+	if (hba_count >= MAX_CONTROLLERS)
+		goto out;
+
 	if (pci_enable_device(pdev))
 		goto out;
 	pci_set_master(pdev);