From: Steven Rostedt (VMware) Date: Sat, 27 Nov 2021 21:45:26 +0000 (-0500) Subject: tracing: Test the 'Do not trace this pid' case in create event X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=27ff768fa21ca3286fcc87c3f38ac67d1a2cbe2d;p=linux.git tracing: Test the 'Do not trace this pid' case in create event When creating a new event (via a module, kprobe, eprobe, etc), the descriptors that are created must add flags for pid filtering if an instance has pid filtering enabled, as the flags are used at the time the event is executed to know if pid filtering should be done or not. The "Only trace this pid" case was added, but a cut and paste error made that case checked twice, instead of checking the "Trace all but this pid" case. Link: https://lore.kernel.org/all/202111280401.qC0z99JB-lkp@intel.com/ Fixes: 6cb206508b62 ("tracing: Check pid filtering when creating events") Reported-by: kernel test robot Signed-off-by: Steven Rostedt (VMware) --- diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index f8965fd50d3be..92be9cb1d7d4b 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c @@ -2693,7 +2693,7 @@ trace_create_new_event(struct trace_event_call *call, lockdep_is_held(&event_mutex)); if (!trace_pid_list_first(pid_list, &first) || - !trace_pid_list_first(pid_list, &first)) + !trace_pid_list_first(no_pid_list, &first)) file->flags |= EVENT_FILE_FL_PID_FILTER; file->event_call = call;