From: Kees Cook Date: Thu, 22 Feb 2018 17:41:40 +0000 (-0800) Subject: kconfig.h: Include compiler types to avoid missed struct attributes X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=28128c61e08eaeced9cc8ec0e6b5d677b5b94690;p=linux.git kconfig.h: Include compiler types to avoid missed struct attributes The header files for some structures could get included in such a way that struct attributes (specifically __randomize_layout from path.h) would be parsed as variable names instead of attributes. This could lead to some instances of a structure being unrandomized, causing nasty GPFs, etc. This patch makes sure the compiler_types.h header is included in kconfig.h so that we've always got types and struct attributes defined, since kconfig.h is included from the compiler command line. Reported-by: Patrick McLean Root-caused-by: Maciej S. Szmigiero Suggested-by: Linus Torvalds Tested-by: Maciej S. Szmigiero Fixes: 3859a271a003 ("randstruct: Mark various structs for randomization") Signed-off-by: Kees Cook Signed-off-by: Linus Torvalds --- diff --git a/include/linux/kconfig.h b/include/linux/kconfig.h index fec5076eda91d..c5fd4ee776ba1 100644 --- a/include/linux/kconfig.h +++ b/include/linux/kconfig.h @@ -64,4 +64,7 @@ */ #define IS_ENABLED(option) __or(IS_BUILTIN(option), IS_MODULE(option)) +/* Make sure we always have all types and struct attributes defined. */ +#include + #endif /* __LINUX_KCONFIG_H */