From: Colin Ian King <colin.king@canonical.com>
Date: Wed, 30 May 2018 18:19:36 +0000 (+0100)
Subject: iio: tsl2x7x/tsl2772: avoid potential division by zero
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=288320f6e9a254bb595b4783c9bdfcc7c0e73153;p=linux.git

iio: tsl2x7x/tsl2772: avoid potential division by zero

It may be possible for tsl2772_get_lux to return a zero lux value
and hence a division by zero can occur when lux_val is zero. Check
for this case and return -ERANGE to avoid the division by zero.

Detected by CoverityScan, CID#1469484 ("Division or modulo by zero")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Brian Masney <masneyb@onstation.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
---

diff --git a/drivers/iio/light/tsl2772.c b/drivers/iio/light/tsl2772.c
index 34d42a2504c92..df5b2a0da96c4 100644
--- a/drivers/iio/light/tsl2772.c
+++ b/drivers/iio/light/tsl2772.c
@@ -582,6 +582,8 @@ static int tsl2772_als_calibrate(struct iio_dev *indio_dev)
 			"%s: failed to get lux\n", __func__);
 		return lux_val;
 	}
+	if (lux_val == 0)
+		return -ERANGE;
 
 	ret = (chip->settings.als_cal_target * chip->settings.als_gain_trim) /
 			lux_val;