From: Al Viro Date: Sat, 27 Jul 2019 20:10:56 +0000 (-0400) Subject: hypfs: don't bother with d_delete() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=29dfeb0b6ae6fcfbc78040bab166215020974f65;p=linux.git hypfs: don't bother with d_delete() If that's not the last reference, d_delete() will do d_drop(). If it is, dput() immediately after it will unhash the sucker anyway, since ->d_delete() the method is always_delete_dentry(). IOW, there's no point trying to turn it into a negative hashed dentry - it won't stick around anyway. Just d_drop() it and be done with that. Signed-off-by: Al Viro --- diff --git a/arch/s390/hypfs/inode.c b/arch/s390/hypfs/inode.c index ccad1398abd40..a4418fc425b8d 100644 --- a/arch/s390/hypfs/inode.c +++ b/arch/s390/hypfs/inode.c @@ -76,7 +76,7 @@ static void hypfs_remove(struct dentry *dentry) else simple_unlink(d_inode(parent), dentry); } - d_delete(dentry); + d_drop(dentry); dput(dentry); inode_unlock(d_inode(parent)); }