From: Sebastian Andrzej Siewior Date: Thu, 17 Jun 2021 07:38:17 +0000 (+0200) Subject: net/netif_receive_skb_core: Use migrate_disable() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=2b4cd14fd995e0a863b2ced4cba0bcd804d89ebc;p=linux.git net/netif_receive_skb_core: Use migrate_disable() The preempt disable around do_xdp_generic() has been introduced in commit bbbe211c295ff ("net: rcu lock and preempt disable missing around generic xdp") For BPF it is enough to use migrate_disable() and the code was updated as it can be seen in commit 3c58482a382ba ("bpf: Provide bpf_prog_run_pin_on_cpu() helper") This is a leftover which was not converted. Use migrate_disable() before invoking do_xdp_generic(). Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: David S. Miller --- diff --git a/net/core/dev.c b/net/core/dev.c index ef8cf7619bafa..439faadab0c2f 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -5277,9 +5277,9 @@ another_round: if (static_branch_unlikely(&generic_xdp_needed_key)) { int ret2; - preempt_disable(); + migrate_disable(); ret2 = do_xdp_generic(rcu_dereference(skb->dev->xdp_prog), skb); - preempt_enable(); + migrate_enable(); if (ret2 != XDP_PASS) { ret = NET_RX_DROP;