From: Wei Yongjun Date: Wed, 11 Jul 2018 13:18:59 +0000 (+0000) Subject: spi: cadence: Fix missing clk_disable_unprepare() on error in cnds_runtime_resume() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=2ba87a9bcc7a10aa28af9fbf5b4354b3168366e2;p=linux.git spi: cadence: Fix missing clk_disable_unprepare() on error in cnds_runtime_resume() Fix the missing clk_disable_unprepare() before return from cnds_runtime_resume() in the error handling case. Signed-off-by: Wei Yongjun Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c index a568f35522f9f..7c88f74f7f470 100644 --- a/drivers/spi/spi-cadence.c +++ b/drivers/spi/spi-cadence.c @@ -739,7 +739,7 @@ static int __maybe_unused cnds_runtime_resume(struct device *dev) ret = clk_prepare_enable(xspi->ref_clk); if (ret) { dev_err(dev, "Cannot enable device clock.\n"); - clk_disable(xspi->pclk); + clk_disable_unprepare(xspi->pclk); return ret; } return 0;