From: Paolo Abeni <pabeni@redhat.com>
Date: Mon, 27 Mar 2023 10:22:21 +0000 (+0200)
Subject: mptcp: avoid unneeded address copy
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=2bb9a37f0e194ed95c70603b0efc7898a5a0d9b4;p=linux.git

mptcp: avoid unneeded address copy

In the syn_recv fallback path, the msk is unused. We can skip
setting the socket address.

Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/mptcp/subflow.c b/net/mptcp/subflow.c
index dadaf85db7201..a11f4c525e011 100644
--- a/net/mptcp/subflow.c
+++ b/net/mptcp/subflow.c
@@ -821,8 +821,6 @@ create_child:
 				goto dispose_child;
 			}
 
-			if (new_msk)
-				mptcp_copy_inaddrs(new_msk, child);
 			mptcp_subflow_drop_ctx(child);
 			goto out;
 		}