From: Zhang Qilong Date: Mon, 21 Sep 2020 12:47:38 +0000 (+0800) Subject: ext4: add trace exit in exception path. X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=2be7d717cafc893d4487cbc7f018d1174537fa2e;p=linux.git ext4: add trace exit in exception path. Missing trace exit in exception path of ext4_sync_file and ext4_ind_map_blocks. Signed-off-by: Zhang Qilong Link: https://lore.kernel.org/r/20200921124738.23352-1-zhangqilong3@huawei.com Signed-off-by: Theodore Ts'o --- diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c index 1d668c8f131ff..6476994d9861d 100644 --- a/fs/ext4/fsync.c +++ b/fs/ext4/fsync.c @@ -150,7 +150,7 @@ int ext4_sync_file(struct file *file, loff_t start, loff_t end, int datasync) ret = file_write_and_wait_range(file, start, end); if (ret) - return ret; + goto out; /* * data=writeback,ordered: diff --git a/fs/ext4/indirect.c b/fs/ext4/indirect.c index a56ce3873e6d4..23e504a40cd70 100644 --- a/fs/ext4/indirect.c +++ b/fs/ext4/indirect.c @@ -593,7 +593,8 @@ int ext4_ind_map_blocks(handle_t *handle, struct inode *inode, if (ext4_has_feature_bigalloc(inode->i_sb)) { EXT4_ERROR_INODE(inode, "Can't allocate blocks for " "non-extent mapped inodes with bigalloc"); - return -EFSCORRUPTED; + err = -EFSCORRUPTED; + goto out; } /* Set up for the direct block allocation */