From: bep <bjorn.erik.pedersen@gmail.com>
Date: Thu, 5 Feb 2015 17:31:11 +0000 (+0100)
Subject: Replace 4 strings.Replace with 1 strings.Replacer
X-Git-Tag: v0.13~66
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=2bee4a15;p=brevno-suite%2Fhugo

Replace 4 strings.Replace with 1 strings.Replacer

Consumes less memory, slightly faster.
---

diff --git a/helpers/content.go b/helpers/content.go
index 3b33b6b1..fe5f26e5 100644
--- a/helpers/content.go
+++ b/helpers/content.go
@@ -69,18 +69,16 @@ var blackfridayExtensionMap = map[string]int{
 	"autoHeaderIds":          blackfriday.EXTENSION_AUTO_HEADER_IDS,
 }
 
+var stripHTMLReplacer = strings.NewReplacer("\n", " ", "</p>", "\n", "<br>", "\n", "<br />", "\n")
+
 // StripHTML accepts a string, strips out all HTML tags and returns it.
 func StripHTML(s string) string {
-	output := ""
 
 	// Shortcut strings with no tags in them
 	if !strings.ContainsAny(s, "<>") {
-		output = s
+		return s
 	} else {
-		s = strings.Replace(s, "\n", " ", -1)
-		s = strings.Replace(s, "</p>", "\n", -1)
-		s = strings.Replace(s, "<br>", "\n", -1)
-		s = strings.Replace(s, "<br />", "\n", -1) // <br /> is the xhtml line break tag
+		s = stripHTMLReplacer.Replace(s)
 
 		// Walk through the string removing all tags
 		b := new(bytes.Buffer)
@@ -97,9 +95,8 @@ func StripHTML(s string) string {
 				}
 			}
 		}
-		output = b.String()
+		return b.String()
 	}
-	return output
 }
 
 // StripEmptyNav strips out empty <nav> tags from content.
diff --git a/helpers/content_test.go b/helpers/content_test.go
index 63ef82f2..6191eb15 100644
--- a/helpers/content_test.go
+++ b/helpers/content_test.go
@@ -14,6 +14,8 @@ func TestStripHTML(t *testing.T) {
 		{"<h1>strip h1 tag <h1>", "strip h1 tag "},
 		{"<p> strip p tag </p>", " strip p tag \n"},
 		{"</br> strip br<br>", " strip br\n"},
+		{"</br> strip br2<br />", " strip br2\n"},
+		{"This <strong>is</strong> a\nnewline", "This is a newline"},
 	}
 	for i, d := range data {
 		output := StripHTML(d.input)