From: Alex Williamson <alex.williamson@redhat.com>
Date: Thu, 14 Jun 2012 18:16:28 +0000 (-0600)
Subject: msix: Note endian TODO item
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=2cf62ad74261a9bd90e5b720e726f0404640b16a;p=qemu.git

msix: Note endian TODO item

MSIX, like PCI, is little endian.  Specifying native is wrong here,
but we need to check the rest of the file to determine if it's
as simple as flipping this macro.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---

diff --git a/hw/msix.c b/hw/msix.c
index 50885acb91..87d316a580 100644
--- a/hw/msix.c
+++ b/hw/msix.c
@@ -224,6 +224,7 @@ static void msix_mmio_write(void *opaque, target_phys_addr_t addr,
 static const MemoryRegionOps msix_mmio_ops = {
     .read = msix_mmio_read,
     .write = msix_mmio_write,
+    /* TODO: MSIX should be LITTLE_ENDIAN. */
     .endianness = DEVICE_NATIVE_ENDIAN,
     .valid = {
         .min_access_size = 4,