From: Daniel P. Berrange Date: Fri, 27 Oct 2017 07:51:59 +0000 (+0100) Subject: sockets: avoid crash when cleaning up sockets for an invalid FD X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=2d7ad7c05e762d5b10a57eba9af1bb6b41700854;p=qemu.git sockets: avoid crash when cleaning up sockets for an invalid FD If socket_listen_cleanup is passed an invalid FD, then querying the socket local address will fail. We must thus be prepared for the returned addr to be NULL Reported-by: Dr. David Alan Gilbert Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Daniel P. Berrange --- diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c index 8b75541ce4..a1cf47e625 100644 --- a/util/qemu-sockets.c +++ b/util/qemu-sockets.c @@ -1079,6 +1079,9 @@ void socket_listen_cleanup(int fd, Error **errp) SocketAddress *addr; addr = socket_local_address(fd, errp); + if (!addr) { + return; + } if (addr->type == SOCKET_ADDRESS_TYPE_UNIX && addr->u.q_unix.path) {