From: Johan Hovold <johan@kernel.org>
Date: Mon, 18 Jan 2021 11:14:22 +0000 (+0100)
Subject: USB: serial: upd78f0730: drop short control-transfer check
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=2dc0e7c37549038444a5202e028ff5625c764012;p=linux.git

USB: serial: upd78f0730: drop short control-transfer check

There's no need to check for short control transfers when sending data
so remove the redundant sanity check.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
---

diff --git a/drivers/usb/serial/upd78f0730.c b/drivers/usb/serial/upd78f0730.c
index 0a2268c479af4..1ca9c18816213 100644
--- a/drivers/usb/serial/upd78f0730.c
+++ b/drivers/usb/serial/upd78f0730.c
@@ -145,14 +145,11 @@ static int upd78f0730_send_ctl(struct usb_serial_port *port,
 
 	kfree(buf);
 
-	if (res != size) {
+	if (res < 0) {
 		struct device *dev = &port->dev;
 
 		dev_err(dev, "failed to send control request %02x: %d\n",
 			*(u8 *)data, res);
-		/* The maximum expected length of a transfer is 6 bytes */
-		if (res >= 0)
-			res = -EIO;
 
 		return res;
 	}