From: Eric Dumazet <edumazet@google.com>
Date: Tue, 13 Feb 2024 06:32:43 +0000 (+0000)
Subject: net: remove dev_base_lock from do_setlink()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=2dd4d828d648e101aaf19326afcdfee8667cb185;p=linux.git

net: remove dev_base_lock from do_setlink()

We hold RTNL here, and dev->link_mode readers already
are using READ_ONCE().

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index e484ba44f23b2..39e66bf3e2384 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -2961,11 +2961,9 @@ static int do_setlink(const struct sk_buff *skb,
 	if (tb[IFLA_LINKMODE]) {
 		unsigned char value = nla_get_u8(tb[IFLA_LINKMODE]);
 
-		write_lock(&dev_base_lock);
 		if (dev->link_mode ^ value)
 			status |= DO_SETLINK_NOTIFY;
 		WRITE_ONCE(dev->link_mode, value);
-		write_unlock(&dev_base_lock);
 	}
 
 	if (tb[IFLA_VFINFO_LIST]) {