From: Daniel P. Berrange Date: Thu, 29 Sep 2016 15:45:38 +0000 (+0100) Subject: ui: remove bogus call to reset_keys() in vnc_init_state X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=2df2041036ee63ff9116631c6214e3ffb5f4bf45;p=qemu.git ui: remove bogus call to reset_keys() in vnc_init_state The vnc_init_state method calls reset_keys() to reset the modifier key state. This was originally added in commit 53762ddb277c690e486d0e17b10591774248c8cf Author: malc Date: Mon Dec 1 20:57:52 2008 +0000 Reset the key modifiers upon client connect This was valid at this time because there was only the single VncState object which was persistent across client connections and so needed resetting. The persistent data was later split off into VncDisplay and VncState was allocated at time of client connection: commit 753b4053311ff1437d99726970b1e7e6bf38249b Author: aliguori Date: Mon Feb 16 14:59:30 2009 +0000 Support multiple VNC clients (Brian Kress) at which point the modifier state is always 0 due to use of g_new0. As such the reset_keys() call has been a no-op ever since. Signed-off-by: Daniel P. Berrange Message-id: 1475163940-26094-8-git-send-email-berrange@redhat.com Signed-off-by: Gerd Hoffmann --- diff --git a/ui/vnc.c b/ui/vnc.c index d1f33d3e36..7c8f07d558 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3086,7 +3086,6 @@ void vnc_init_state(VncState *vs) vnc_write(vs, "RFB 003.008\n", 12); vnc_flush(vs); vnc_read_when(vs, protocol_version, 12); - reset_keys(vs); if (vs->vd->lock_key_sync) vs->led = qemu_add_led_event_handler(kbd_leds, vs);