From: Christophe JAILLET Date: Sat, 21 Mar 2020 06:40:48 +0000 (+0100) Subject: HID: rmi: Simplify an error handling path in 'rmi_hid_read_block()' X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=2e1b9e1edff7fe19d37f0a5993ac03c5389af809;p=linux.git HID: rmi: Simplify an error handling path in 'rmi_hid_read_block()' The 'RMI_READ_REQUEST_PENDING' bit is already cleared in the error handling path. There is no need to reset it twice. Signed-off-by: Christophe JAILLET Signed-off-by: Jiri Kosina --- diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c index 9ce22acdfaca2..8cffa84c96503 100644 --- a/drivers/hid/hid-rmi.c +++ b/drivers/hid/hid-rmi.c @@ -217,7 +217,6 @@ static int rmi_hid_read_block(struct rmi_transport_dev *xport, u16 addr, ret = rmi_write_report(hdev, data->writeReport, data->output_report_size); if (ret != data->output_report_size) { - clear_bit(RMI_READ_REQUEST_PENDING, &data->flags); dev_err(&hdev->dev, "failed to write request output report (%d)\n", ret);