From: Fabian Frederick <fabf@skynet.be>
Date: Fri, 25 Sep 2020 13:16:59 +0000 (+0200)
Subject: vxlan: check rtnl_configure_link return code correctly
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=2eabcb8afe74304458ee47ee175bc16b770b7d20;p=linux.git

vxlan: check rtnl_configure_link return code correctly

rtnl_configure_link is always checked if < 0 for error code.

Signed-off-by: Fabian Frederick <fabf@skynet.be>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 14f903d09c010..1e9ab1002281c 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -3890,7 +3890,7 @@ static int __vxlan_dev_create(struct net *net, struct net_device *dev,
 	}
 
 	err = rtnl_configure_link(dev, NULL);
-	if (err)
+	if (err < 0)
 		goto unlink;
 
 	if (f) {