From: Mika Westerberg <mika.westerberg@linux.intel.com>
Date: Thu, 28 Dec 2023 14:49:45 +0000 (+0200)
Subject: thunderbolt: Log an error if DPTX request is not cleared
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=2ec67a48cf8f18b8c6cecc70dcd5d52cbf8eba7e;p=linux.git

thunderbolt: Log an error if DPTX request is not cleared

This helps debugging issues around DisplayPort bandwidth allocation
mode.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---

diff --git a/drivers/thunderbolt/usb4.c b/drivers/thunderbolt/usb4.c
index 4b35898aa2166..f4fba144105d0 100644
--- a/drivers/thunderbolt/usb4.c
+++ b/drivers/thunderbolt/usb4.c
@@ -2858,8 +2858,10 @@ static int usb4_dp_port_wait_and_clear_cm_ack(struct tb_port *port,
 		usleep_range(50, 100);
 	} while (ktime_before(ktime_get(), end));
 
-	if (val & ADP_DP_CS_8_DR)
+	if (val & ADP_DP_CS_8_DR) {
+		tb_port_warn(port, "timeout waiting for DPTX request to clear\n");
 		return -ETIMEDOUT;
+	}
 
 	ret = tb_port_read(port, &val, TB_CFG_PORT,
 			   port->cap_adap + ADP_DP_CS_2, 1);