From: Saiyam Doshi Date: Sat, 7 Sep 2019 17:39:10 +0000 (+0530) Subject: gpio: remove explicit comparison with 0 X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=2efc6bfadb0b9c873e11ab8da37f4f69aa215d25;p=linux.git gpio: remove explicit comparison with 0 No need to compare return value with 0. In case of non-zero return value, the if condition will be true. This makes intent a bit more clear to the reader. "if (x) then", compared to "if (x is not zero) then". Signed-off-by: Saiyam Doshi Link: https://lore.kernel.org/r/20190907173910.GA9547@SD Signed-off-by: Linus Walleij --- diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index f5b2649e2893a..158e327a1285d 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -851,7 +851,7 @@ static irqreturn_t lineevent_irq_thread(int irq, void *p) } ret = kfifo_put(&le->events, ge); - if (ret != 0) + if (ret) wake_up_poll(&le->wait, EPOLLIN); return IRQ_HANDLED;