From: Gustavo A. R. Silva Date: Tue, 16 Jun 2020 23:09:23 +0000 (-0500) Subject: irqchip/imx-intmux: Use struct_size() helper in devm_kzalloc() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=2f7a9bda42f74e1169fcd9ef55c8ade989ef8bba;p=linux.git irqchip/imx-intmux: Use struct_size() helper in devm_kzalloc() Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. This code was detected with the help of Coccinelle and, audited and fixed manually. Signed-off-by: Gustavo A. R. Silva Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20200616230923.GA24937@embeddedor --- diff --git a/drivers/irqchip/irq-imx-intmux.c b/drivers/irqchip/irq-imx-intmux.c index c27577c811268..54d8bb4fc5a11 100644 --- a/drivers/irqchip/irq-imx-intmux.c +++ b/drivers/irqchip/irq-imx-intmux.c @@ -210,8 +210,7 @@ static int imx_intmux_probe(struct platform_device *pdev) return -EINVAL; } - data = devm_kzalloc(&pdev->dev, sizeof(*data) + - channum * sizeof(data->irqchip_data[0]), GFP_KERNEL); + data = devm_kzalloc(&pdev->dev, struct_size(data, irqchip_data, channum), GFP_KERNEL); if (!data) return -ENOMEM;