From: Tim Collier Date: Wed, 25 Jul 2018 19:30:31 +0000 (+0100) Subject: staging: wlan-ng: remove volatile from reapable field in hfa384x_usbctlx X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=318c66d456b81ce15b5e17b551d7db6ecc4aeac6;p=linux.git staging: wlan-ng: remove volatile from reapable field in hfa384x_usbctlx Fix checkpatch.pl warning: "Use of volatile is usually wrong: see Documentation/process/volatile-considered-harmful.rs" reapable is not used to access h/w directly, so volatile is not necessary. >From reading the code, the contexts in which the field may be updated/accessed across threads are protected by the hw->ctlxq.lock spinlock, where hw is the device struct, so appears thread-safe. Signed-off-by: Tim Collier Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h index 67a944c0d6908..992ebaa1071ff 100644 --- a/drivers/staging/wlan-ng/hfa384x.h +++ b/drivers/staging/wlan-ng/hfa384x.h @@ -1176,7 +1176,7 @@ struct hfa384x_usbctlx { enum ctlx_state state; /* Tracks running state */ struct completion done; - volatile int reapable; /* Food for the reaper task */ + int reapable; /* Food for the reaper task */ ctlx_cmdcb_t cmdcb; /* Async command callback */ ctlx_usercb_t usercb; /* Async user callback, */