From: Felipe Balbi Date: Mon, 7 May 2018 12:19:31 +0000 (+0300) Subject: usb: dwc3: gadget: init req->{direction,epnum} from alloc_request() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=31a2f5a7e13633712a97721458f6c5980c2d386e;p=linux.git usb: dwc3: gadget: init req->{direction,epnum} from alloc_request() We dont' need to touch req->direction or req->epnum from ep_queue(). It's enough that we initialize both fields from alloc_request() and just keep them for the entire lifetime of the request. No functional changes. Signed-off-by: Felipe Balbi --- diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index cca692e0bfd8a..4ca593cff15e2 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -837,6 +837,7 @@ static struct usb_request *dwc3_gadget_ep_alloc_request(struct usb_ep *ep, if (!req) return NULL; + req->direction = dep->direction; req->epnum = dep->number; req->dep = dep; @@ -1285,8 +1286,6 @@ static int __dwc3_gadget_ep_queue(struct dwc3_ep *dep, struct dwc3_request *req) req->request.actual = 0; req->request.status = -EINPROGRESS; - req->direction = dep->direction; - req->epnum = dep->number; trace_dwc3_ep_queue(req);