From: Takashi Iwai <tiwai@suse.de>
Date: Mon, 18 Feb 2019 13:38:06 +0000 (+0100)
Subject: ALSA: ac97: Fix of-node refcount unbalance
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=31d2350d602511efc9ef626b848fe521233b0387;p=linux.git

ALSA: ac97: Fix of-node refcount unbalance

ac97_of_get_child_device() take the refcount of the node explicitly
via of_node_get(), but this leads to an unbalance.  The
for_each_child_of_node() loop itself takes the refcount for each
iteration node, hence you don't need to take the extra refcount
again.

Fixes: 2225a3e6af78 ("ALSA: ac97: add codecs devicetree binding")
Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/ac97/bus.c b/sound/ac97/bus.c
index 9f0c480489ef0..9cbf6927abe96 100644
--- a/sound/ac97/bus.c
+++ b/sound/ac97/bus.c
@@ -84,7 +84,7 @@ ac97_of_get_child_device(struct ac97_controller *ac97_ctrl, int idx,
 		if ((idx != of_property_read_u32(node, "reg", &reg)) ||
 		    !of_device_is_compatible(node, compat))
 			continue;
-		return of_node_get(node);
+		return node;
 	}
 
 	return NULL;