From: Andrey Grodzovsky Date: Fri, 5 May 2017 15:30:06 +0000 (-0400) Subject: drm/amd/display: Fix race. X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=3273d3bfe58094d9c7b52448399e20f496475afe;p=linux.git drm/amd/display: Fix race. Problem : A race between two adjecent page flips makes the earlier one to release an alocated frame buffer for the subsequent one - since there are 2 frambuffer swapped back and forth between flips, the 'new' fb of the later flip is actually the 'previous' fb for the earlier flip. Fix: Don't set fb->address = 0 in cleanup hook, this is unnecessery and erases the newly cached adress that was set in prepare_fb of the second flip. Signed-off-by: Andrey Grodzovsky Reviewed-by: Andrey Grodzovsky Acked-by: Harry Wentland Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_types.c index 6bd8048ba21ee..9c0dc9d076260 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_types.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_types.c @@ -1622,9 +1622,7 @@ static void dm_plane_helper_cleanup_fb( amdgpu_bo_unpin(rbo); amdgpu_bo_unreserve(rbo); amdgpu_bo_unref(&rbo); - } - - afb->address = 0; + }; } int dm_create_validation_set_for_connector(struct drm_connector *connector,