From: Markus Armbruster <armbru@redhat.com>
Date: Fri, 11 Jan 2013 10:25:00 +0000 (+0100)
Subject: qemu-ga: Plug fd leak on ga_channel_listen_accept() error path
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=32c16620dda8ba16f6d6bcd20efefdec8975af77;p=qemu.git

qemu-ga: Plug fd leak on ga_channel_listen_accept() error path

Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---

diff --git a/qga/channel-posix.c b/qga/channel-posix.c
index ca9e4aaaf9..9a5c05d666 100644
--- a/qga/channel-posix.c
+++ b/qga/channel-posix.c
@@ -46,6 +46,7 @@ static gboolean ga_channel_listen_accept(GIOChannel *channel,
     ret = ga_channel_client_add(c, client_fd);
     if (ret) {
         g_warning("error setting up connection");
+        close(client_fd);
         goto out;
     }
     accepted = true;