From: J. Bruce Fields <bfields@redhat.com>
Date: Thu, 21 Jan 2021 22:57:37 +0000 (-0500)
Subject: nfsd4: simplify process_lookup1
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=33311873adb0d55c287b164117b5b4bb7b1bdc40;p=linux.git

nfsd4: simplify process_lookup1

This STALE_CLIENTID check is redundant with the one in
lookup_clientid().

There's a difference in behavior is in case of memory allocation
failure, which I think isn't a big deal.

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 1d2cd6a88f61d..f9f89229dba6d 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -4680,8 +4680,6 @@ nfsd4_process_open1(struct nfsd4_compound_state *cstate,
 	struct nfs4_openowner *oo = NULL;
 	__be32 status;
 
-	if (STALE_CLIENTID(&open->op_clientid, nn))
-		return nfserr_stale_clientid;
 	/*
 	 * In case we need it later, after we've already created the
 	 * file and don't want to risk a further failure: