From: Jérôme Pouiller Date: Fri, 10 Apr 2020 13:32:25 +0000 (+0200) Subject: staging: wfx: set all parameters before starting AP X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=3393eebd9ddbe952628b297374befd10d73e2741;p=linux.git staging: wfx: set all parameters before starting AP Current code start AP and then configure the different parameters. Since all the configuration is sent quickly after AP started, it works. However, it is not very nice. In add, last firmware releases start to disallow incorrect settings. Signed-off-by: Jérôme Pouiller Link: https://lore.kernel.org/r/20200410133239.438347-6-Jerome.Pouiller@silabs.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/wfx/sta.c b/drivers/staging/wfx/sta.c index 92bf317b57bbb..1e7ff2ba33d83 100644 --- a/drivers/staging/wfx/sta.c +++ b/drivers/staging/wfx/sta.c @@ -604,7 +604,6 @@ int wfx_start_ap(struct ieee80211_hw *hw, struct ieee80211_vif *vif) { struct wfx_vif *wvif = (struct wfx_vif *)vif->drv_priv; - hif_start(wvif, &vif->bss_conf, wvif->channel); wfx_upload_keys(wvif); if (wvif_count(wvif->wdev) <= 1) hif_set_block_ack_policy(wvif, 0xFF, 0xFF); @@ -612,6 +611,7 @@ int wfx_start_ap(struct ieee80211_hw *hw, struct ieee80211_vif *vif) wfx_update_filtering(wvif); wfx_upload_ap_templates(wvif); wfx_fwd_probe_req(wvif, false); + hif_start(wvif, &vif->bss_conf, wvif->channel); return 0; }