From: Geert Uytterhoeven <geert+renesas@glider.be>
Date: Mon, 27 Nov 2017 14:46:27 +0000 (+0100)
Subject: of: unittest: Remove bogus overlay mutex release from overlay_data_add()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=33acc40d00bc66f2d6e84441b6c46e03bd8acfa9;p=linux.git

of: unittest: Remove bogus overlay mutex release from overlay_data_add()

overlay_data_add() never takes the special overlay mutex, so it must not
be released in the error patch.

Presumably the call to of_overlay_mutex_unlock() is a relic from v1 of
the patch.

Fixes: f948d6d8b792bb90 ("of: overlay: avoid race condition between applying multiple overlays")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Frank Rowand <frank.rowand@sony.com>
Signed-off-by: Rob Herring <robh@kernel.org>
---

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index e568b1e82501b..0f8052f1355c0 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -2165,7 +2165,6 @@ static int __init overlay_data_add(int onum)
 	ret = of_overlay_apply(info->np_overlay, &info->overlay_id);
 	if (ret < 0) {
 		pr_err("of_overlay_apply() (ret=%d), %d\n", ret, onum);
-		of_overlay_mutex_unlock();
 		goto out_free_np_overlay;
 	}